Skip to content

Switch from setup.py to pyproject.toml#76

Merged
jcfr merged 1 commit into
scikit-build:masterfrom
autopub:pyproject
Feb 3, 2024
Merged

Switch from setup.py to pyproject.toml#76
jcfr merged 1 commit into
scikit-build:masterfrom
autopub:pyproject

Conversation

@justinmayer

Copy link
Copy Markdown
Contributor

Primary Problem

The main problem is that #73 has been merged but has not yet been shipped as a packaged release to PyPI.

Secondary Problem

As a workaround, one might be tempted to install from current master in order to get the needed fix from #73:

python -m pip install git+https://github.com/j0057/github-release.git

However, the above command yields a fatal error because the version number generated by the (deprecated) setuptools-version-command package required in setup.py does not conform to PEP 440:

    File "/private/var/folders/r7/xxdlb6114759yn1rltsq8nwh0000gn/T/pip-build-env-40g3i5io/overlay/lib/python3.12/site-packages/setuptools/_vendor/packaging/version.py", line 198, in __init__
      raise InvalidVersion(f"Invalid version: '{version}'")
  setuptools.extern.packaging.version.InvalidVersion: Invalid version: '1.5.9-5-geaec743'

Unsuccessful Resolution in setup.py

I spent entirely too much time trying to fix this in setup.py, attempting to replace the deprecated setuptools-version-command package with setuptools-scm, but that just resulted in setup.py yielding a version number of 0.0.0 every time.

Solution: Replace setup.py with pyproject.toml

Ultimately, by far the easiest solution to the Secondary Problem of not being able to install the current master branch of this project was to switch from setup.py to pyproject.toml.

No other changes are present in this pull request, in an effort to keep the scope as focused as possible.

@jcfr

jcfr commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the detailed report and contributions 🙏

@jcfr jcfr merged commit e80cbe4 into scikit-build:master Feb 3, 2024
@justinmayer

Copy link
Copy Markdown
Contributor Author

Glad to help. Thank you for the quick merge! 😁

Echoing the request from December 2023, any chance a new release could be issued containing the fix from #73?

@jcfr

jcfr commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

re: release

Back in December @j0057 and I exchanged few emails and agreed on transferring the project to the scikit-build GitHub organization.

I just followed with them about the transfer as well as shared maintenance of the corresponding PyPi project.

As soon as this is completed, we will be moving forward with publishing a release.

Thanks for your patience 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants